Change in osmo-bsc[master]: log: tweaks and more context in osmo_bsc_sigtran_send()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Aug 27 23:05:04 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10642


Change subject: log: tweaks and more context in osmo_bsc_sigtran_send()
......................................................................

log: tweaks and more context in osmo_bsc_sigtran_send()

Change-Id: I3d51f17b0f6ceb0e5237b4d6d5252c701fc2fe6b
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/10642/1

diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index 96f0687..f39bb92 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -363,16 +363,18 @@
 	if (msg->len >= 3) {
 		switch (msg->data[0]) {
 		case BSSAP_MSG_BSS_MANAGEMENT:
-			LOGP(DMSC, LOGL_INFO, "Tx MSC %s\n", gsm0808_bssmap_name(msg->data[2]));
+			LOGP(DMSC, LOGL_INFO, "Tx MSC: BSS Management: %s\n",
+			     gsm0808_bssmap_name(msg->data[2]));
 			break;
 		case BSSAP_MSG_DTAP:
-			LOGP(DMSC, LOGL_INFO, "Tx MSC DTAP\n");
+			LOGP(DMSC, LOGL_INFO, "Tx MSC: DTAP\n");
 			break;
 		default:
-			LOGP(DMSC, LOGL_ERROR, "Tx MSC (unknwon message type)\n");
+			LOGP(DMSC, LOGL_ERROR, "Tx MSC: unknown message type: 0x%x\n",
+			     msg->data[0]);
 		}
 	} else
-		LOGP(DMSC, LOGL_ERROR, "Tx MSC (message too short)\n");
+		LOGP(DMSC, LOGL_ERROR, "Tx MSC: message too short: %u\n", msg->len);
 
 	if (a_reset_conn_ready(msc) == false) {
 		LOGP(DMSC, LOGL_ERROR, "MSC is not connected. Dropping.\n");

-- 
To view, visit https://gerrit.osmocom.org/10642
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d51f17b0f6ceb0e5237b4d6d5252c701fc2fe6b
Gerrit-Change-Number: 10642
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180827/f028f298/attachment.htm>


More information about the gerrit-log mailing list