Change in osmo-bts[master]: fix ip.access dyn TS for osmo-bts-trx

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Aug 25 14:39:36 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10598 )

Change subject: fix ip.access dyn TS for osmo-bts-trx
......................................................................


Patch Set 1:

to change it:

* change structure of trx_chan_desc[]. It relies on chan_nr to indicate PDCH-ness or not and adjust all users -- probably not.

* OR special-case dyn ts instead of using trx_chan_desc. Make sure all users that need this do so, hopefully only trx_sched_set_lchan()?

* obtain or pass in the lchan->type to trx_sched_set_lchan(), I think it's possible with get_lchan_by_chan_nr(l1t->trx, chan_nr)

IMHO it's ok to use the slightly unusual cbits internally: it's less complex to rule out side effects. I can spend some more time to try and solve it with lchan->type, if anyone insists.


-- 
To view, visit https://gerrit.osmocom.org/10598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eed8a135f2ab7e7c0d15ad5c76430b7fe54df3d
Gerrit-Change-Number: 10598
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Aug 2018 14:39:36 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180825/4ea5ef4a/attachment.htm>


More information about the gerrit-log mailing list