Change in libosmocore[master]: gsmtap_util: make sure SO_REUSEADDR is applied for GSMTAP

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10588 )

Change subject: gsmtap_util: make sure SO_REUSEADDR is applied for GSMTAP
......................................................................

gsmtap_util: make sure SO_REUSEADDR is applied for GSMTAP

When gsmtap adding a new sink it does not supply OSMO_SOCK_F_UDP_REUSEADDR
in order to have SO_REUSEADDR applied. In most cases, the gsmtap sink is
just receiving packets to toss them immediately, so having one of them
is sufficient.  However, in other use cases - particularly virt_phy -
we actually want to receve and process GSMTAP messages via multicast
Applying SO_REUSEADDR (like we did before disabling it globally for UDP
in I4a8ffb8d598aca88801a4a0322944d7cdd8d4047 on August 1st) resolves
the issue.

Change-Id: I1399a428467ca12f1564a14eb8ffb294d4f59874
Related: OS#3497
---
M src/gsmtap_util.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c
index b21c690..385b467 100644
--- a/src/gsmtap_util.c
+++ b/src/gsmtap_util.c
@@ -254,7 +254,9 @@
 
 	if (osmo_sockaddr_is_local((struct sockaddr *)&ss, ss_len) == 1) {
 		rc = osmo_sock_init_sa((struct sockaddr *)&ss, SOCK_DGRAM,
-					IPPROTO_UDP, OSMO_SOCK_F_BIND);
+				       IPPROTO_UDP,
+				       OSMO_SOCK_F_BIND |
+				       OSMO_SOCK_F_UDP_REUSEADDR);
 		if (rc >= 0)
 			return rc;
 	}

-- 
To view, visit https://gerrit.osmocom.org/10588
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1399a428467ca12f1564a14eb8ffb294d4f59874
Gerrit-Change-Number: 10588
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180824/99cb6fff/attachment.htm>