Change in libosmocore[master]: gsmtap_util: make sure SO_REUSEADDR is applied for GSMTAP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Aug 24 06:36:32 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10588 )

Change subject: gsmtap_util: make sure SO_REUSEADDR is applied for GSMTAP
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

fine, except the commitlog.

https://gerrit.osmocom.org/#/c/10588/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/10588/1//COMMIT_MSG@11
PS1, Line 11: its technically a multicast
            : application
this is not true.  It is typically not a multicast application as it doesn't use IP multicast addresses, and the listeners don't use any of the socket options to bind to a given multicast IP either.

I think it's best to actually describe the problem with virtphy here, and indicating that virtphy uses GSMTAP in multicast mode.



-- 
To view, visit https://gerrit.osmocom.org/10588
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1399a428467ca12f1564a14eb8ffb294d4f59874
Gerrit-Change-Number: 10588
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 24 Aug 2018 06:36:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180824/f8dade2b/attachment.htm>


More information about the gerrit-log mailing list