Change in osmocom-bb[master]: osmocon: fix use of an initialized variable

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10576 )

Change subject: osmocon: fix use of an initialized variable
......................................................................

osmocon: fix use of an initialized variable

osmocon.c: In function ‘read_file’:
osmocon.c:317:3: warning: ‘fd’ may be used uninitialized in this function

Change-Id: If07c58d5b55c18c05345607064eace02748935f8
---
M src/host/osmocon/osmocon.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c
index 131eab7..a9497dc 100644
--- a/src/host/osmocon/osmocon.c
+++ b/src/host/osmocon/osmocon.c
@@ -314,7 +314,8 @@
 	dnload.data = malloc(MAX_HDR_SIZE + payload_size);
 
 	if (!dnload.data) {
-		close(fd);
+		if (!chainload)
+			close(fd);
 		fprintf(stderr, "No memory\n");
 		return -ENOMEM;
 	}

-- 
To view, visit https://gerrit.osmocom.org/10576
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If07c58d5b55c18c05345607064eace02748935f8
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180823/291235fe/attachment.htm>