Change in libosmo-sccp[master]: ipa_asp_fsm: init: expect IPA ID ACK, not GET

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Aug 20 20:29:54 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10162 )

Change subject: ipa_asp_fsm: init: expect IPA ID ACK, not GET
......................................................................


Patch Set 2: Code-Review+2

I'm not entirely happy about unconditionally merging this.  I would suggest to review various pcap files of IPA establishment against different peer implementations and then try to understnd what's really the right thing to do.  However, given that the IPA code in this specific implementation is currently not used at all, I'm happy to say "I don't care [yet]".


-- 
To view, visit https://gerrit.osmocom.org/10162
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icffda98579e676ab6ca63c9c22cf5d151c4fe95f
Gerrit-Change-Number: 10162
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Mon, 20 Aug 2018 20:29:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180820/e95ec9e9/attachment.htm>


More information about the gerrit-log mailing list