Change in osmo-iuh[master]: fix decoding of incoming X.213 NSAP addr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Aug 20 20:21:50 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10545 )

Change subject: fix decoding of incoming X.213 NSAP addr
......................................................................

fix decoding of incoming X.213 NSAP addr

Fix ranap_transp_layer_addr_decode() to test == 7 instead of > 7: If a femto
cell sends its Transport Layer Address as X.213 NSAP IPv4, we receive 3 header
bytes and four IP-address bytes, so the length is exactly 7.

This function is very vague on numerous other decoding details, but this patch
only fixes the vital length check that makes 3G usable with X.213 NSAP.

Related: OS#3420
Change-Id: I2cd1b2d8e1c1ae707cfc0dc7961a2b31ecdf29e0
---
M src/iu_helpers.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/iu_helpers.c b/src/iu_helpers.c
index 5e78293..39b0521 100644
--- a/src/iu_helpers.c
+++ b/src/iu_helpers.c
@@ -109,7 +109,7 @@
 	buf = trasp_layer_addr->buf;
 	len = trasp_layer_addr->size;
 
-	if (buf[0] == 0x35 && len > 7)
+	if (buf[0] == 0x35 && len == 7)
 		rc = inet_ntop(AF_INET, buf + 3, addr, addr_len);
 	else if (len > 3)
 		rc = inet_ntop(AF_INET, buf, addr, addr_len);

-- 
To view, visit https://gerrit.osmocom.org/10545
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cd1b2d8e1c1ae707cfc0dc7961a2b31ecdf29e0
Gerrit-Change-Number: 10545
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180820/65b3ea93/attachment.htm>


More information about the gerrit-log mailing list