This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Keith Whyte gerrit-no-reply at lists.osmocom.orgKeith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/10490 ) Change subject: Logging: in check_rtp_create() log the IP address in human readable dotted quad format. ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10490/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/10490/1/src/mncc.c@386 PS1, Line 386: inet_ntoa(net) > inet_ntoa is specified as being used with ip addresses in *network byte order*. […] I copied the code from http://git.osmocom.org/osmo-sip-connector/tree/src/sdp.c#n168 and http://git.osmocom.org/osmo-sip-connector/tree/src/sdp.c#n185 which would appear to implement the same (error). Is it the case that in practice (at least on my x86 platform) that ntohl() and htonl() will give the same result? https://stackoverflow.com/questions/15863775/ntohl-vs-htonl-in-little-endian This may be related then to https://osmocom.org/issues/3431 ? -- To view, visit https://gerrit.osmocom.org/10490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I298b13836cc6b9c5888f931deca61132d31da035 Gerrit-Change-Number: 10490 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Fri, 17 Aug 2018 21:37:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180817/898c913a/attachment.htm>