Change in osmo-bts[master]: cosmetic: unify measurement sample handling in one function

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10491


Change subject: cosmetic: unify measurement sample handling in one function
......................................................................

cosmetic: unify measurement sample handling in one function

In l1sap.c we call lchan_new_ul_meas() and lchan_meas_check_compute()
directly in sequence. Lets unify thos two steps inside measurement.c so
that we only need to call one function from l1sap.c.

Change-Id: If48bc7442dfaab8c36b93949f741de6e836e792a
Related: OS#2975
---
M include/osmo-bts/measurement.h
M src/common/l1sap.c
M src/common/measurement.c
3 files changed, 16 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/91/10491/1

diff --git a/include/osmo-bts/measurement.h b/include/osmo-bts/measurement.h
index e32c8e8..283b0ff 100644
--- a/include/osmo-bts/measurement.h
+++ b/include/osmo-bts/measurement.h
@@ -8,4 +8,6 @@
 
 int lchan_meas_check_compute(struct gsm_lchan *lchan, uint32_t fn);
 
+void lchan_meas_process_measurement(struct gsm_lchan *lchan, struct bts_ul_meas *ulm, uint32_t fn);
+
 #endif
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 8936674..00ead8d 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -528,11 +528,7 @@
 	/* we assume that symbol period is 1 bit: */
 	set_ms_to_data(lchan, info_meas_ind->ta_offs_256bits / 256, true);
 
-	lchan_new_ul_meas(lchan, &ulm, info_meas_ind->fn);
-
-	/* Check measurement period end and prepare the UL measurment
-	 * report at Meas period End*/
-	lchan_meas_check_compute(lchan, info_meas_ind->fn);
+	lchan_meas_process_measurement(lchan, &ulm, info_meas_ind->fn);
 
 	return 0;
 }
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 01f1e5d..a75b54d 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -477,3 +477,16 @@
 
 	return 1;
 }
+
+/* Process a single uplink measurement sample. This function is called from
+ * l1sap.c every time a measurement indication is received. It collects the
+ * measurement samples and automatically detects the end oft the measurement
+ * interval. */
+void lchan_meas_process_measurement(struct gsm_lchan *lchan, struct bts_ul_meas *ulm, uint32_t fn)
+{
+	lchan_new_ul_meas(lchan, ulm, fn);
+
+	/* Check measurement period end and prepare the UL
+	 * measurment report at Meas period End */
+	lchan_meas_check_compute(lchan, fn);
+}

-- 
To view, visit https://gerrit.osmocom.org/10491
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If48bc7442dfaab8c36b93949f741de6e836e792a
Gerrit-Change-Number: 10491
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180817/012dd980/attachment.htm>