Change in osmo-sip-connector[master]: Implement MNCC Cause <-> SIP Call Error mapping

[Keith Whyte]

Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/9271 )

Change subject: Implement MNCC Cause <-> SIP Call Error mapping
......................................................................


Patch Set 8: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/9271/8/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/9271/8/src/mncc.c@145
PS8, Line 145: 			 __func__, osmo_mncc_name(msg_type), mncc.cause.value);
It would be nice to see a human readable cause here.


https://gerrit.osmocom.org/#/c/9271/8/src/mncc.c@393
PS8, Line 393: 	struct in_addr net = { .s_addr = ntohl(leg->base.ip) };
I should move this to another commit.


https://gerrit.osmocom.org/#/c/9271/8/src/sip.c
File src/sip.c:

https://gerrit.osmocom.org/#/c/9271/8/src/sip.c@181
PS8, Line 181: 					case 404:
We don't have any constants for a sip status anywhere.


https://gerrit.osmocom.org/#/c/9271/8/src/sip.c@265
PS8, Line 265: 	switch (_leg->cause) {
Is this OK here like this, or should one create a separate function?



-- 
To view, visit https://gerrit.osmocom.org/9271
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9796c8ecdfdd68274e9b32e748d32a4b8dc273
Gerrit-Change-Number: 9271
Gerrit-PatchSet: 8
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 17 Aug 2018 14:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180817/d7420ac2/attachment.htm>