Change in osmocom-bb[master]: fix time delta calculations in sched_clck.c

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10489 )

Change subject: fix time delta calculations in sched_clck.c
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/10489/1/src/host/trxcon/sched_clck.c
File src/host/trxcon/sched_clck.c:

https://gerrit.osmocom.org/#/c/10489/1/src/host/trxcon/sched_clck.c@98
PS1, Line 98: 
> I would avoid passing a negative value in there. […]
Does this have to be changed as part of this patch? I'd rather treat it as a separate issue.


https://gerrit.osmocom.org/#/c/10489/2/src/host/trxcon/sched_clck.c
File src/host/trxcon/sched_clck.c:

https://gerrit.osmocom.org/#/c/10489/2/src/host/trxcon/sched_clck.c@173
PS2, Line 173: 		while (duration.tv_nsec >= 1000000000) {
> What about something like this to avoid a loop? […]
Nice, I like it. Thanks for this suggestion.



-- 
To view, visit https://gerrit.osmocom.org/10489
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93f90685c6d6dc28dfc4ad48c998e0eac113cf8
Gerrit-Change-Number: 10489
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Aug 2018 14:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180817/f968318f/attachment.htm>