This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10481 )
Change subject: signal: Introduce API osmo_signal_talloc_ctx_init
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/10481/1/src/signal.c
File src/signal.c:
https://gerrit.osmocom.org/#/c/10481/1/src/signal.c@39
PS1, Line 39: void *tall_sigh_ctx;
Oh, wow, it is not even being initialized to NULL.
Moreover, it is not static, so it's exposed...
https://gerrit.osmocom.org/#/c/10481/1/src/signal.c@55
PS1, Line 55: tall_sigh_ctx = talloc_size(root_ctx, 0);
: talloc_set_name_const(tall_sigh_ctx, "osmo_signal");
Feel free to use talloc_init() here.
--
To view, visit https://gerrit.osmocom.org/10481
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09
Gerrit-Change-Number: 10481
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 18:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180816/ab5c7357/attachment.htm>