Change in osmo-ttcn3-hacks[master]: update DTX fill frame test expectations

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10414 )

Change subject: update DTX fill frame test expectations
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10414/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/10414/1/bts/BTS_Tests.ttcn@3840
PS1, Line 3840: 52, 53, 54, 55, 56, 57, 58, 5
> this is listing all eitght bursts that are required during DTX on a TCH/F. […]
I have made some changes that I believe align with your suggestions, which I will push here soon.
However, the test is still failing with:

BTS_Tests.ttcn:3912 Received DTX TCH fill frame with bad frame number: 268 (mod 104: 60) (mod 26: 8)

I have read up on the structure and hierarchy of GSM frames, and what you're suggesting now makes a lot of sense to me.
But I am still struggling to understand the exact relationship of TCH/F frame numbers sent by osmo-bts and received in TTCN3.

For an unrelated AGCH PCH frame, sent by osmo-bts on chan_nr=144 fn=159, I can easily make out the corresponding frame
in the TTCN3 test log (the channel matches and the frame number also matches).

For TCH/F, when osmo-bts is sending:
l1sap.c:805 000160/00/04/07/04 sending fill frame TCH chan_nr=9 fn=160 dtx=enabled
then I cannot locate the corresponding frame in the TTCN3 test's log by frame number (even though frame 160 should start a block).

However, for this frame:
l1sap.c:805 000264/00/04/09/08 sending fill frame TCH chan_nr=9 fn=264 dtx=enabled
I can locate a logged message that looks like it corresponds in terms of channel, frame number, and payload:

19:45:38.982505 6 L1CTL_PortType.ttcn:212 dec_L1ctlDlMessageLV(): Decoded @L1CTL_Types.L1ctlDlMessageLV: {
    len := 39,
    msg := {
        header := {
            msg_type := L1CTL_DATA_IND (3),
            flags := {
                padding := '0000000'B,
                f_done := false
            },
            padding := '0000'O
        },
        dl_info := {
            chan_nr := {
                u := {
                    ch0 := RSL_CHAN_NR_Bm_ACCH (1)
                },
                tn := 1
            },
            link_id := {
                c := FACCH_SDCCH (0),
                na := false,
                prio := SAPI0_PRIO_NORMAL (0),
                sapi := 0
            },
            arfcn := {
                pcs := false,
                arfcn := 871
            },
            frame_nr := 264,
            rx_level := 60,
            snr := 0,
            num_biterr := 0,
            fire_crc := 0
        },
        payload := {
            data_ind := {
                payload := '0303012B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O
            }
        }
    }
}



-- 
To view, visit https://gerrit.osmocom.org/10414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie573b54ab5654f027c470aa7a565d2b5b97dc74b
Gerrit-Change-Number: 10414
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 18:05:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180815/c9e8c50e/attachment.htm>