Change in osmo-msc[master]: osmo-msc: track the use of talloc NULL memory contexts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Aug 14 13:22:37 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10447 )

Change subject: osmo-msc: track the use of talloc NULL memory contexts
......................................................................

osmo-msc: track the use of talloc NULL memory contexts

Tracking NULL memory contexts allows one to detect memory chunks,
allocated outside the application's root context, which in most
cases are results of some mistake.

In b874486e8e48f033204bfcc86871dd851266d440 the repotring of
NULL-context state was introduced, but without asking talloc
to track the use of NULL memory contexts it doesn't make sense.

Change-Id: I4b5e3946ee21c7d0ed6c66b1059dbce5ad312f88
---
M src/osmo-msc/msc_main.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 2159d65..1a10278 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -521,6 +521,9 @@
 {
 	int rc;
 
+	/* Track the use of talloc NULL memory contexts */
+	talloc_enable_null_tracking();
+
 	msc_vty_info.copyright	= osmomsc_copyright;
 
 	tall_msc_ctx = talloc_named_const(NULL, 1, "osmo_msc");

-- 
To view, visit https://gerrit.osmocom.org/10447
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b5e3946ee21c7d0ed6c66b1059dbce5ad312f88
Gerrit-Change-Number: 10447
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180814/9f5df302/attachment.htm>


More information about the gerrit-log mailing list