Change in osmo-msc[master]: osmo-msc: free the VTY talloc context on exit

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Aug 14 13:22:37 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10450 )

Change subject: osmo-msc: free the VTY talloc context on exit
......................................................................

osmo-msc: free the VTY talloc context on exit

This is a follow up change before enabling the track of NULL talloc
contexts. Since there is no other way to deinitialize libosmovty,
let's free its root context on exit. Otherwise one would see
lots of memory chunks on exit...

Change-Id: I278f85f023210de6b4626d4493d10d20996f606a
---
M src/osmo-msc/msc_main.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index b1bb52a..2159d65 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -710,6 +710,9 @@
 	talloc_report_full(tall_msc_ctx, stderr);
 	talloc_free(tall_msc_ctx);
 
+	/* FIXME: VTY code still uses NULL-context */
+	talloc_free(tall_vty_ctx);
+
 	/**
 	 * Report the heap state of NULL context, then free,
 	 * so both ASAN and Valgrind are happy...

-- 
To view, visit https://gerrit.osmocom.org/10450
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I278f85f023210de6b4626d4493d10d20996f606a
Gerrit-Change-Number: 10450
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180814/30254c50/attachment.htm>


More information about the gerrit-log mailing list