Change in libosmo-sccp[master]: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10442 )

Change subject: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free
......................................................................


Patch Set 1:

parts are allocated like this:

int xua_msg_add_data(struct xua_msg *msg, uint16_t tag,
		      uint16_t len, uint8_t *dat)
{
	struct xua_msg_part *part;

	part = talloc_zero(msg, struct xua_msg_part);

so probably no need, but still more clear to free them explicitly and cleanup the list anyway.


-- 
To view, visit https://gerrit.osmocom.org/10442
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ca8aea50b3715890b9ea0290471e95caed4624
Gerrit-Change-Number: 10442
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:23:10 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180813/921afa76/attachment.htm>