Change in osmocom-bb[master]: trxcon: suppress WARNING log message on NEIGH_PM_REQ

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Aug 11 11:51:14 UTC 2018


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10432


Change subject: trxcon: suppress WARNING log message on NEIGH_PM_REQ
......................................................................

trxcon: suppress WARNING log message on NEIGH_PM_REQ

Let's differentiate between an 'expected' unimplemented message
like L1CTL_NEIGH_PM_REQ and a truly unknonw message type

This makes the following WARNING messages disappear:

<0001> l1ctl.c:798 Unknown MSG type 26: 1a 00 00 00 01 00 00 64 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Change-Id: Id76993056fb514e6fb0242d505205316c61bb965
---
M src/host/trxcon/l1ctl.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/32/10432/1

diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c
index 74400be..134425f 100644
--- a/src/host/trxcon/l1ctl.c
+++ b/src/host/trxcon/l1ctl.c
@@ -793,6 +793,9 @@
 		return l1ctl_rx_tch_mode_req(l1l, msg);
 	case L1CTL_CRYPTO_REQ:
 		return l1ctl_rx_crypto_req(l1l, msg);
+	case L1CTL_NEIGH_PM_REQ:
+		LOGP(DL1C, LOGL_DEBUG, "Ignoring L1CTL_NEIGH_PM_REQ\n");
+		return -EINVAL;
 	default:
 		LOGP(DL1C, LOGL_ERROR, "Unknown MSG type %u: %s\n", l1h->msg_type,
 			osmo_hexdump(msgb_data(msg), msgb_length(msg)));

-- 
To view, visit https://gerrit.osmocom.org/10432
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id76993056fb514e6fb0242d505205316c61bb965
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180811/968acf9d/attachment.htm>


More information about the gerrit-log mailing list