Change in osmo-gsm-tester[master]: bts_nanobts: Fix pwsup_list increasing its size every new test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Aug 9 11:00:37 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10411


Change subject: bts_nanobts: Fix pwsup_list increasing its size every new test
......................................................................

bts_nanobts: Fix pwsup_list increasing its size every new test

variables under class section are shared among all instances, and are
used unless the specific class instance attribute is set. As a result,
the same pwsup_list object was being re-used.

Take the chance to do the same with the _pcu var, since we want same
behavior for it.

See for reference: https://stackoverflow.com/a/1716730

Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
---
M src/osmo_gsm_tester/bts_nanobts.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/11/10411/1

diff --git a/src/osmo_gsm_tester/bts_nanobts.py b/src/osmo_gsm_tester/bts_nanobts.py
index 7f0151f..a18f205 100644
--- a/src/osmo_gsm_tester/bts_nanobts.py
+++ b/src/osmo_gsm_tester/bts_nanobts.py
@@ -28,13 +28,13 @@
 
 class NanoBts(bts.Bts):
 
-    pwsup_list = []
-    _pcu = None
 ##############
 # PROTECTED
 ##############
     def __init__(self, suite_run, conf):
         super().__init__(suite_run, conf, 'nanobts_%s' % conf.get('label', 'nolabel'), 'nanobts')
+        self.pwsup_list = []
+        self._pcu = None
 
     def _configure(self):
         if self.bsc is None:

-- 
To view, visit https://gerrit.osmocom.org/10411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
Gerrit-Change-Number: 10411
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180809/a8d4dbc8/attachment.htm>


More information about the gerrit-log mailing list