Change in libosmocore[master]: bssgp: introduce flush queue functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Aug 7 16:50:06 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10371 )

Change subject: bssgp: introduce flush queue functions
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/10371/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/10371/1//COMMIT_MSG@13
PS1, Line 13: 
it might make sense to dsecribe when this might be useful to do.


https://gerrit.osmocom.org/#/c/10371/1/src/gb/gprs_bssgp.c
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/#/c/10371/1/src/gb/gprs_bssgp.c@1267
PS1, Line 1267: void bssgp_fc_flush_queue(struct bssgp_flow_control *fc)
please let's add doxygen comments for all newly introduced API.  I know it sucks that existing APIs are not fully documented, but let's make sure at least new API is documented from day one.



-- 
To view, visit https://gerrit.osmocom.org/10371
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29b6ad6742ddf9b0b58b4af37d9a1cf18e019325
Gerrit-Change-Number: 10371
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 16:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180807/b54e8b32/attachment.htm>


More information about the gerrit-log mailing list