This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10333 ) Change subject: GSCON: avoid sending clear when not connected ...................................................................... Patch Set 1: Code-Review-1 IMHO, the low-level BSSMAP sending functions should cotnain any checks so it's always safe to call them, no matter what the state is. This way it's easy to get things right in a generic way. It might be sufficient to check for conn==NULL (I don't know), or it might be required to actually pass the fsm_inst to the transmit functions, so they can do whatever state checks and dereference conn only in case it is valid. -- To view, visit https://gerrit.osmocom.org/10333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eaa983702224e5995a388ea9890ee04212eb569 Gerrit-Change-Number: 10333 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 05 Aug 2018 07:05:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180805/6672685a/attachment.htm>