This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10323 Change subject: hlr_ussd.c: avoid using CR and NL in IUSE responses ...................................................................... hlr_ussd.c: avoid using CR and NL in IUSE responses According to GSM TS 03.38, section 6.1.2.1, CR symbol at the end is optional, and moreover libosmogsm encoding API will carry about the bit padding itself. Change-Id: I09e8a67758698f3b7a578eab956311e269d091ee --- M src/hlr_ussd.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/23/10323/1 diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c index 7b981bb..d8bbcb5 100644 --- a/src/hlr_ussd.c +++ b/src/hlr_ussd.c @@ -297,7 +297,7 @@ if (strlen(subscr.msisdn) == 0) snprintf(buf, sizeof(buf), "You have no MSISDN!"); else - snprintf(buf, sizeof(buf), "Your extension is %s\r", subscr.msisdn); + snprintf(buf, sizeof(buf), "Your extension is %s", subscr.msisdn); ss_tx_ussd_7bit(ss, true, req->invoke_id, buf); break; case -ENOENT: @@ -315,7 +315,7 @@ const struct osmo_gsup_message *gsup, const struct ss_request *req) { char buf[GSM0480_USSD_7BIT_STRING_LEN+1]; - snprintf(buf, sizeof(buf), "Your IMSI is %s!\n", ss->imsi); + snprintf(buf, sizeof(buf), "Your IMSI is %s!", ss->imsi); ss_tx_ussd_7bit(ss, true, req->invoke_id, buf); return 0; } -- To view, visit https://gerrit.osmocom.org/10323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I09e8a67758698f3b7a578eab956311e269d091ee Gerrit-Change-Number: 10323 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180802/c318a344/attachment.htm>