Change in libosmo-sccp[master]: Migrate from ipa_ccm_idtag_parse() to ipa_ccm_id_resp_parse()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10297 )

Change subject: Migrate from ipa_ccm_idtag_parse() to ipa_ccm_id_resp_parse()
......................................................................

Migrate from ipa_ccm_idtag_parse() to ipa_ccm_id_resp_parse()

In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f
we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement
of ipa_ccm_idtag_parse().

The main difference is that the returned "value" parts now have
a correct reported "length", whereas before this commit they all
reported a one-byte too-long "length" for each IE.

Change-Id: I3c79d3bb56cc1370b9922e64d13d2d5508fd8039
---
M src/xua_asp_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 93c76cb..78a4f25 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -806,7 +806,7 @@
 	case IPA_ASP_E_ID_RESP:
 		/* resolve the AS based on the identity provided by peer. */
 		msg = data;
-			rc = ipa_ccm_idtag_parse(&tp, msgb_l2(msg)+2, msgb_l2len(msg)-2);
+			rc = ipa_ccm_id_resp_parse(&tp, msgb_l2(msg)+1, msgb_l2len(msg)-1);
 		if (rc < 0) {
 			LOGPFSML(fi, LOGL_ERROR, "Error %d parsing ID_RESP TLV: %s\n", rc,
 				 msgb_hexdump(msg));

-- 
To view, visit https://gerrit.osmocom.org/10297
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c79d3bb56cc1370b9922e64d13d2d5508fd8039
Gerrit-Change-Number: 10297
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180801/5634628f/attachment.htm>