Change in libosmocore[master]: cosmetic: More context / naming / comment for test_idtag_parsing()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10290 )

Change subject: cosmetic: More context / naming / comment for test_idtag_parsing()
......................................................................

cosmetic: More context / naming / comment for test_idtag_parsing()

Change-Id: I1ebeba2067549e0dd1541fa84715d44321ff3b43
---
M tests/utils/utils_test.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/utils/utils_test.c b/tests/utils/utils_test.c
index a146190..eec13ca 100644
--- a/tests/utils/utils_test.c
+++ b/tests/utils/utils_test.c
@@ -175,7 +175,8 @@
 	struct tlv_parsed tvp;
 	int rc;
 
-        static uint8_t data[] = {
+	/* IPA CCM IDENTITY REQUEST message: 8bit length followed by respective value */
+        static uint8_t id_get_data[] = {
 		0x01, 0x08,
 		0x01, 0x07,
 		0x01, 0x02,
@@ -188,7 +189,7 @@
 		0x11, 0x24, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
         };
 
-	rc = ipa_ccm_idtag_parse_off(&tvp, data, sizeof(data), 1);
+	rc = ipa_ccm_idtag_parse_off(&tvp, id_get_data, sizeof(id_get_data), 1);
 	OSMO_ASSERT(rc == 0);
 
 	OSMO_ASSERT(TLVP_PRESENT(&tvp, 8));

-- 
To view, visit https://gerrit.osmocom.org/10290
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ebeba2067549e0dd1541fa84715d44321ff3b43
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180801/78580e8b/attachment.htm>