[MERGED] osmo-ttcn3-hacks[master]: ggsn: Disable GTP-U tx sequence number by default

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: ggsn: Disable GTP-U tx sequence number by default
......................................................................


ggsn: Disable GTP-U tx sequence number by default

GTP-U transmit sequence numbers are entirely optional and probably
don't serve any real purpose in real-world deployments.

While OsmoGGSN in userspace implements support for it, the kernel GTP-U
implementation doesn't.  This means a number of tests fail against
kernel GTP-U only for that reason.

Let's switch all tests to disable GTP-U sequence numbers, and only
enable it in one specific test.  This way, we can execute the tests
also against kernel GTP-U.

Related: OS#3215
Change-Id: I666f5276749ef6a1a4dc170a3b9a747f626f6b2c
---
M ggsn_tests/GGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index cb6aabf..d099681 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -93,7 +93,7 @@
 		var uint16_t g_d_seq_nr;
 
 		port TELNETasp_PT GGSNVTY;
-		var boolean use_gtpu_txseq := true;
+		var boolean use_gtpu_txseq := false;
 	}
 
 	private function f_init_vty() runs on GT_CT {

-- 
To view, visit https://gerrit.osmocom.org/7935
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I666f5276749ef6a1a4dc170a3b9a747f626f6b2c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>