This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/7928/1/sgsnemu/Makefile.am File sgsnemu/Makefile.am: Line 10: AM_CFLAGS += -DGTP_KERNEL $(LIBGTPNL_CFLAGS) > Why not using ENABLE_GTP_KERNEL in the source code directly? this is just reusing the existing define like before the patch. So your comment is a valid comment, but it would be a different change. -- To view, visit https://gerrit.osmocom.org/7928 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic53a971136edd0d8871fbd6746d7b0090ce3a188 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes