This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/7922/1/lib/tun.c File lib/tun.c: Line 259: memcpy(&dstaddr, dstaddr, sizeof(*dstaddr)); > This doesn't make sense. It needs to be removed from here, and done in the agreed. Line 495: return tun_setaddr4(this, addr, dstaddr, netmask); /* TODO dstaddr */ > TODO? this is just moving around existing coe from line 419..422 before -- To view, visit https://gerrit.osmocom.org/7922 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I139a950dd81a4b1199953be1608cd109a060f562 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes