This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/7928/1/lib/tun.h File lib/tun.h: Line 45: extern int tun_new(struct tun_t **tun, const char *dev_name, int fd0, int fd1u, bool use_kernel); I'd put the use_kernel parameter before the fd* ones, as it states whether the they are actually used or not (they are only used when using kernel right?) https://gerrit.osmocom.org/#/c/7928/1/sgsnemu/Makefile.am File sgsnemu/Makefile.am: Line 10: AM_CFLAGS += -DGTP_KERNEL $(LIBGTPNL_CFLAGS) Why not using ENABLE_GTP_KERNEL in the source code directly? -- To view, visit https://gerrit.osmocom.org/7928 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic53a971136edd0d8871fbd6746d7b0090ce3a188 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes