This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: fix segfault in case of kernel gtp-u ...................................................................... fix segfault in case of kernel gtp-u There's a problem during the initial start-up of osmo-ggsn in case of kernel gtp-u: apn->ggsn->gsn is not yet set while parsing the 'apn' nodes from the config file. This member is only set after the last 'apn' node has been parsed at the end of the 'ggsn' node. Closes: OS#3217 Change-Id: I022a5e5ebc1f155e8f94938856d310462f79bbe8 --- M ggsn/ggsn.c 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index cb11c49..bbdb5c8 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -284,6 +284,14 @@ apn_stop(apn, false); return -1; } + if (apn->ggsn->gsn == NULL) { + /* skip bringing up the APN now if the GSN is not initialized yet. + * This happens during initial load of the config file, as the + * "no shutdown" in the ggsn node only happens after the "apn" nodes + * are brought up */ + LOGPAPN(LOGL_NOTICE, apn, "Skipping APN start\n"); + return 0; + } /* use GTP kernel module for data packet encapsulation */ if (gtp_kernel_init(apn->ggsn->gsn, apn->tun.cfg.dev_name, &apn->v4.cfg.ifconfig_prefix, apn->tun.cfg.ipup_script) < 0) { -- To view, visit https://gerrit.osmocom.org/7919 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I022a5e5ebc1f155e8f94938856d310462f79bbe8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder