osmo-bsc[master]: abis_rsl.c: abis_rsl_rx_cchan: Print msg type name for unimp...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 23 08:40:24 UTC 2018


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/7887/1/src/libbsc/abis_rsl.c
File src/libbsc/abis_rsl.c:

Line 2076: 			rsl_msg_name(rslh->c.msg_type), rslh->c.msg_type);
I would simply go for the string-name only, as it will be rendered as "unknown 0x%x" anyway for unknown mesage types.


-- 
To view, visit https://gerrit.osmocom.org/7887
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e2e40bcb9365420f7e79d8d954505b0d2376bed
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list