This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/7882 respond with NACK for non-hopping BTS with multiple ARFCN In addition to logging an error, send a NACK if the BSC attempts to set more than one ARFCN in Radio Carrier Attributes for a BTS which does not support frequency hopping. Change-Id: Ia72e23a3f08f825cf9cf0d9a55302d13cfed51d6 Related: OS#2295 --- M src/common/oml.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/82/7882/1 diff --git a/src/common/oml.c b/src/common/oml.c index 088b3a0..5c9885e 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -807,8 +807,7 @@ if (length != 2) { LOGP(DOML, LOGL_ERROR, "Expecting only one ARFCN, " "because hopping not supported\n"); - /* FIXME: send NACK */ - return -ENOTSUP; + return oml_fom_ack_nack(msg, NM_NACK_MSGINCONSIST_PHYSCFG); } memcpy(&_value, value, 2); arfcn = ntohs(_value); -- To view, visit https://gerrit.osmocom.org/7882 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia72e23a3f08f825cf9cf0d9a55302d13cfed51d6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>