This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.org
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/#/c/7743/3//COMMIT_MSG
Commit Message:
Line 14: into a common implementation, but that is left for future work.
> If you're intending to let it stay like this, I would actually still oppose
Log message has been updated to clearly explain what's intended.
https://gerrit.osmocom.org/#/c/7743/3/src/hlr.c
File src/hlr.c:
Line 64: llist_for_each_entry(co, &g_hlr->gs->clients, list) {
> cosmetic wise, I'd prefer a separate function that is called from the loop
I'll look at that in a follow-up change.
Line 100: gsup.cn_domain = OSMO_GSUP_CN_DOMAIN_CS;
> ?
Ooops, fixed.
--
To view, visit https://gerrit.osmocom.org/7743
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06c43ece2b48dc63d599000eb6d6d51e08963067
Gerrit-PatchSet: 3
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes