[PATCH] osmo-bsc[master]: properly skip paging is OML link is down

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Apr 19 12:44:45 UTC 2018


Review at  https://gerrit.osmocom.org/7881

properly skip paging is OML link is down

If the OML link is found down while a paging request is issued,
no paging message is sent. However, we were still counting such
pagings as an actual attempt, and counted them towards the number
of available slots on the paging request queue.

Move the OML link check to the caller of page_ms() where the
accounting steps can be properly skipped as they should be.

Change-Id: I5b6db681da7d45c49e1f2f99d7789c8a29372ef3
Related: OS#2901
---
M src/libbsc/paging.c
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/7881/1

diff --git a/src/libbsc/paging.c b/src/libbsc/paging.c
index 910a9b6..24be692 100644
--- a/src/libbsc/paging.c
+++ b/src/libbsc/paging.c
@@ -80,10 +80,6 @@
 	unsigned int page_group;
 	struct gsm_bts *bts = request->bts;
 
-	/* the bts is down.. we will just wait for the paging to expire */
-	if (!bts->oml_link)
-		return;
-
 	log_set_context(LOG_CTX_BSC_SUBSCR, request->bsub);
 
 	LOGP(DPAG, LOGL_INFO, "(bts=%d) Going to send paging commands: imsi: %s tmsi: "
@@ -214,6 +210,10 @@
 			goto skip_paging;
 	}
 
+	/* Skip paging if the bts is down. */
+	if (!request->bts->oml_link)
+		goto skip_paging;
+
 	/* handle the paging request now */
 	page_ms(request);
 	paging_bts->available_slots--;

-- 
To view, visit https://gerrit.osmocom.org/7881
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b6db681da7d45c49e1f2f99d7789c8a29372ef3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>



More information about the gerrit-log mailing list