osmo-hlr[master]: rewrite subscriber_update_notify() without calls into luop

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Apr 18 07:13:18 UTC 2018


Patch Set 2:

I didn't remember that we had the cn domain indicator as a GSUP IE. I only knew it as an IE on the Iu-side. This is different from MAP. In MAP. UpdateLocation + UpdateGprsLocation are two different distinct operations, so there's no need for that.

I agree that in presence of a GSUP CN_DOMAIN IE, we don't need to do ugly things like parsing the string of the IPA CCM UNIT_ID.

We don't need to worry about doing CS + PS LU at the same time, as this is not present in MAP either and we should stay rather simple to have a simple translation.  So 
OSMO_GSUP_CN_DOMAIN_PS gets translated to UpdateGprsLocation and OSMO_GSUP_CN_DOMAIN_CS gets translated to UpdateLocation, and that's it.

-- 
To view, visit https://gerrit.osmocom.org/7743
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c43ece2b48dc63d599000eb6d6d51e08963067
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list