[MERGED] osmo-bts[master]: common/sysinfo.c: Fix no return on on-void function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Apr 17 19:56:57 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: common/sysinfo.c: Fix no return on on-void function
......................................................................


common/sysinfo.c: Fix no return on on-void function

src/common/sysinfo.c:147:1: warning: control reaches end of non-void function [-Wreturn-type]
 }

The compiler warning is actually a false positive since we call
OSMO_ABORT on that path, but let's add a return anyway so the
compiler doesn't throw a warning.

Change-Id: I9b4e06927489a8bc20ce173279a01415a8c4295a
---
M src/common/sysinfo.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/sysinfo.c b/src/common/sysinfo.c
index f5f9c7e..5c66e08 100644
--- a/src/common/sysinfo.c
+++ b/src/common/sysinfo.c
@@ -144,6 +144,7 @@
 	/* this should never bve reached. We must transmit a BCCH
 	 * message on the normal BCCH in all cases. */
 	OSMO_ASSERT(0);
+	return 0;
 }
 
 uint8_t num_agch(struct gsm_bts_trx *trx, const char * arg)

-- 
To view, visit https://gerrit.osmocom.org/7857
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b4e06927489a8bc20ce173279a01415a8c4295a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list