This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgPatch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/7784/3/src/libbsc/acc_ramp.c File src/libbsc/acc_ramp.c: Line 182: if (trx_is_usable(trx)) /* cross-check with operational state */ > As discussed a few mins ago, when coming from S_NM_STATECHG_OPER signal in Indeed. Fixed in next patch set. Line 190: break; > we can probably removed this break to print an error too, unless NULL is re Sure. Line 222: if (trigger_ramping && !osmo_timer_pending(&acc_ramp->step_timer)) > do we really need this osmo_timer_pending check here? This should never hap I'm afraid of putting an assert in there. It should not be needed in the next patch set so I've just removed the check entirely. -- To view, visit https://gerrit.osmocom.org/7784 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3291439655598fb5ddc891a3e4cc35b0bad250f Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-HasComments: Yes