This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/7773/1/include/osmocom/netif/jibuf.h File include/osmocom/netif/jibuf.h: Line 1: #ifndef _JIBUF_H_ we genearlly use "#pragma once" these days. Line 21: struct jibuf { all new data structures and symbols of osmocom libraries must be prefixed with "osmo_", so it should be an "osmo_jibuf", just like all the API calls below. https://gerrit.osmocom.org/#/c/7773/1/src/jibuf.c File src/jibuf.c: Line 1: /* (C) 2017 by Pau Espin Pedrol <pespin at sysmocom.de> copyright is with your employer sysmocom, you can list yourself as the author only, sorry. Line 6: * (at your option) any later version. good idea to add SPDX-License-Identifier to new files right from the beginning. https://gerrit.osmocom.org/#/c/7773/1/tests/jibuf/jibuf_test.c File tests/jibuf/jibuf_test.c: Line 1: /* (C) 207 by Pau Espin Pedrol <pespin at sysmocom.de> same as my comments in jibuf.c, plus the year is wrong - or I seriously underestimated your age :P -- To view, visit https://gerrit.osmocom.org/7773 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9688ba9c4d5b733b9f29d0f15f73750f9271ef55 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes