This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7772/1/src/libbsc/acc_ramp.c
File src/libbsc/acc_ramp.c:
Line 267: if (trx0 && trx_is_usable(trx0) && trx0->mo.nm_state.administrative == NM_STATE_UNLOCKED) {
I know that we are then enabling ramping when we receive the event to become unlocked (NM_STATE_UNLOCKED). What about the other condition here? Do we also start it when trx_is_usable() goes from return false to returning true?
Shouldn't the trx_is_usable() already contain the check for the administrative state? I'm not sure if it makes sense to state it is usable while it is actually locked on the administrate side.
--
To view, visit https://gerrit.osmocom.org/7772
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I054829a936f0aa1e3fa34fad6466a1cd6150e307
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes