This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged.
Change subject: MSC_Tests: fix TC_mo_crcx_ran_reject
......................................................................
MSC_Tests: fix TC_mo_crcx_ran_reject
The testcase intentionally responds to the RAN sided CRCX
with a garbeled message to cause the MGCP handlin inside
the MSC to fail. The MSC is then expected not to perform
further MGCP operations since it did not get a proper
response to the first CRCX, so the specific endpoint name
is not known, eventually preventing from doing an MDCX.
However, the testcase responds to incoming DLCX commands,
instead setting the verdict to fail.
Also the altstep that dispatches the message after the
errornous MGCP response unconditionally catches all BSSAP
messages before entering the sub-altstep
as_clear_cmd_compl_disc() that handles the clearing of
the connection. Eventually the clear command is never
received in this sub-altstep.
- Make sure the verdict is set to fail when an MGCP
message is received after the errornous response to
the CRCX.
- Remove the unconditional BSSAP.receive in order to
be able to dispatch the clear command properly
- Update the expected-results.log file
Change-Id: I806491741d310e4410f6cb4ce0309235e9bf4300
Related: OS#2882
---
M msc/MSC_Tests.ttcn
M msc/expected-results.log
2 files changed, 82 insertions(+), 90 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index b5108c7..bb28c74 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1267,17 +1267,14 @@
BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_CC_REL_COMPL(cpars.transaction_id)));
repeat;
}
- [] BSSAP.receive {
- repeat;
- }
[] MNCC.receive { repeat; }
[] GSUP.receive { repeat; }
- [] MGCP.receive(tr_DLCX(?)) -> value mgcp_cmd {
- MGCP.send(ts_DLCX_ACK2(mgcp_cmd.line.trans_id));
- f_create_mgcp_delete_ep(cpars.mgcp_ep);
- repeat;
- }
- [] MGCP.receive { repeat; }
+ /* Note: As we did not respond properly to the CRCX from the MSC we
+ * expect the MSC to omit any further MGCP operation (At least in the
+ * the current implementation, there is no recovery mechanism implemented
+ * and a DLCX can not be performed as the MSC does not know a specific
+ * endpoint yet. */
+ [] MGCP.receive { setverdict(fail, "Unexpected MGCP message"); self.stop; }
[] as_clear_cmd_compl_disc();
}
}
diff --git a/msc/expected-results.log b/msc/expected-results.log
index 92c38a0..ebda8a4 100644
--- a/msc/expected-results.log
+++ b/msc/expected-results.log
@@ -1,115 +1,110 @@
<?xml version="1.0"?>
-<testsuite name='Titan' tests='45' failures='12' errors='1' skipped='0' inconc='0' time='497.00'>
- <testcase classname='MSC_Tests' name='TC_cr_before_reset' time='4.009127'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_tmsi' time='1.035697'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_notmsi' time='1.045502'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_reject' time='6.041282'>
+<testsuite name='Titan' tests='45' failures='12' errors='1' skipped='0' inconc='0' time='230.00'>
+ <testcase classname='MSC_Tests' name='TC_cr_before_reset' time='4.016365'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_tmsi' time='1.103294'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_notmsi' time='1.095196'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_reject' time='6.089528'>
<failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
- MSC_Tests.ttcn:1829 MSC_Tests control part
+ MSC_Tests.ttcn:1832 MSC_Tests control part
MSC_Tests.ttcn:502 TC_lu_imsi_reject testcase
</failure>
</testcase>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_timeout_gsup' time='11.044559'>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_timeout_gsup' time='11.115838'>
<failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
- MSC_Tests.ttcn:1830 MSC_Tests control part
+ MSC_Tests.ttcn:1833 MSC_Tests control part
MSC_Tests.ttcn:531 TC_lu_imsi_timeout_gsup testcase
</failure>
</testcase>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi' time='1.036704'/>
- <testcase classname='MSC_Tests' name='TC_cmserv_imsi_unknown' time='1.021692'/>
- <testcase classname='MSC_Tests' name='TC_lu_and_mo_call' time='4.291881'/>
- <testcase classname='MSC_Tests' name='TC_lu_auth_sai_timeout' time='6.032964'/>
- <testcase classname='MSC_Tests' name='TC_lu_auth_sai_err' time='1.028503'/>
- <testcase classname='MSC_Tests' name='TC_lu_clear_request' time='2.067166'>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi' time='1.332147'/>
+ <testcase classname='MSC_Tests' name='TC_cmserv_imsi_unknown' time='1.072018'/>
+ <testcase classname='MSC_Tests' name='TC_lu_and_mo_call' time='4.363851'/>
+ <testcase classname='MSC_Tests' name='TC_lu_auth_sai_timeout' time='6.104096'/>
+ <testcase classname='MSC_Tests' name='TC_lu_auth_sai_err' time='1.095694'/>
+ <testcase classname='MSC_Tests' name='TC_lu_clear_request' time='2.092570'>
<failure type='fail-verdict'>Got a second Clear Command, only one expected
- MSC_Tests.ttcn:1832 MSC_Tests control part
+ MSC_Tests.ttcn:1839 MSC_Tests control part
MSC_Tests.ttcn:704 TC_lu_clear_request testcase
</failure>
</testcase>
- <testcase classname='MSC_Tests' name='TC_lu_disconnect' time='2.028908'/>
- <testcase classname='MSC_Tests' name='TC_lu_by_imei' time='6.030599'/>
- <testcase classname='MSC_Tests' name='TC_lu_by_tmsi_noauth_unknown' time='1.246818'/>
- <testcase classname='MSC_Tests' name='TC_imsi_detach_by_imsi' time='1.238427'/>
- <testcase classname='MSC_Tests' name='TC_imsi_detach_by_tmsi' time='1.228194'/>
- <testcase classname='MSC_Tests' name='TC_imsi_detach_by_imei' time='1.233577'/>
- <testcase classname='MSC_Tests' name='TC_emerg_call_imei_reject' time='6.025962'>
- <failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
- MSC_Tests.ttcn:1843 MSC_Tests control part
- MSC_Tests.ttcn:903 TC_emerg_call_imei_reject testcase
- </failure>
- </testcase>
- <testcase classname='MSC_Tests' name='TC_emerg_call_imsi' time='4.295068'/>
- <testcase classname='MSC_Tests' name='TC_cm_serv_req_vgcs_reject' time='6.251082'>
- <failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
- MSC_Tests.ttcn:1845 MSC_Tests control part
- MSC_Tests.ttcn:940 TC_cm_serv_req_vgcs_reject testcase
- </failure>
- </testcase>
- <testcase classname='MSC_Tests' name='TC_cm_serv_req_vbs_reject' time='6.249901'>
+ <testcase classname='MSC_Tests' name='TC_lu_disconnect' time='2.072759'/>
+ <testcase classname='MSC_Tests' name='TC_lu_by_imei' time='6.269669'/>
+ <testcase classname='MSC_Tests' name='TC_lu_by_tmsi_noauth_unknown' time='1.305121'/>
+ <testcase classname='MSC_Tests' name='TC_imsi_detach_by_imsi' time='1.266751'/>
+ <testcase classname='MSC_Tests' name='TC_imsi_detach_by_tmsi' time='1.303229'/>
+ <testcase classname='MSC_Tests' name='TC_imsi_detach_by_imei' time='1.277434'/>
+ <testcase classname='MSC_Tests' name='TC_emerg_call_imei_reject' time='6.099546'>
<failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
MSC_Tests.ttcn:1846 MSC_Tests control part
- MSC_Tests.ttcn:961 TC_cm_serv_req_vbs_reject testcase
+ MSC_Tests.ttcn:909 TC_emerg_call_imei_reject testcase
</failure>
</testcase>
- <testcase classname='MSC_Tests' name='TC_cm_serv_req_lcs_reject' time='6.244740'>
- <failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
- MSC_Tests.ttcn:1847 MSC_Tests control part
- MSC_Tests.ttcn:982 TC_cm_serv_req_lcs_reject testcase
- </failure>
- </testcase>
- <testcase classname='MSC_Tests' name='TC_cm_reest_req_reject' time='6.250134'>
+ <testcase classname='MSC_Tests' name='TC_emerg_call_imsi' time='4.352641'/>
+ <testcase classname='MSC_Tests' name='TC_cm_serv_req_vgcs_reject' time='6.294919'>
<failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
MSC_Tests.ttcn:1848 MSC_Tests control part
- MSC_Tests.ttcn:1003 TC_cm_reest_req_reject testcase
+ MSC_Tests.ttcn:946 TC_cm_serv_req_vgcs_reject testcase
</failure>
</testcase>
- <testcase classname='MSC_Tests' name='TC_lu_auth_2G_fail' time='1.042594'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_13_13' time='1.052763'/>
- <testcase classname='MSC_Tests' name='TC_cl3_no_payload' time='1.021188'/>
- <testcase classname='MSC_Tests' name='TC_cl3_rnd_payload' time='5.996049'>
+ <testcase classname='MSC_Tests' name='TC_cm_serv_req_vbs_reject' time='6.298783'>
+ <failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
+ MSC_Tests.ttcn:1849 MSC_Tests control part
+ MSC_Tests.ttcn:967 TC_cm_serv_req_vbs_reject testcase
+ </failure>
+ </testcase>
+ <testcase classname='MSC_Tests' name='TC_cm_serv_req_lcs_reject' time='6.324982'>
+ <failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
+ MSC_Tests.ttcn:1850 MSC_Tests control part
+ MSC_Tests.ttcn:988 TC_cm_serv_req_lcs_reject testcase
+ </failure>
+ </testcase>
+ <testcase classname='MSC_Tests' name='TC_cm_reest_req_reject' time='6.316325'>
+ <failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
+ MSC_Tests.ttcn:1851 MSC_Tests control part
+ MSC_Tests.ttcn:1009 TC_cm_reest_req_reject testcase
+ </failure>
+ </testcase>
+ <testcase classname='MSC_Tests' name='TC_lu_auth_2G_fail' time='1.323815'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_13_13' time='1.284995'/>
+ <testcase classname='MSC_Tests' name='TC_cl3_no_payload' time='1.091612'/>
+ <testcase classname='MSC_Tests' name='TC_cl3_rnd_payload' time='6.027316'>
<failure type='fail-verdict'>Timeout waiting for ClearCommand or SCCP Release
- MSC_Tests.ttcn:1852 MSC_Tests control part
- MSC_Tests.ttcn:1125 TC_cl3_rnd_payload testcase
+ MSC_Tests.ttcn:1855 MSC_Tests control part
+ MSC_Tests.ttcn:1131 TC_cl3_rnd_payload testcase
</failure>
</testcase>
- <testcase classname='MSC_Tests' name='TC_establish_and_nothing' time='6.263255'>
+ <testcase classname='MSC_Tests' name='TC_establish_and_nothing' time='6.309272'>
<failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
- MSC_Tests.ttcn:1853 MSC_Tests control part
- MSC_Tests.ttcn:1142 TC_establish_and_nothing testcase
- </failure>
- </testcase>
- <testcase classname='MSC_Tests' name='TC_mo_setup_and_nothing' time='31.481429'>
- <failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
- MSC_Tests.ttcn:1854 MSC_Tests control part
- MSC_Tests.ttcn:1166 TC_mo_setup_and_nothing testcase
- </failure>
- </testcase>
- <testcase classname='MSC_Tests' name='TC_mo_crcx_ran_timeout' time='5.267724'/>
- <testcase classname='MSC_Tests' name='TC_mo_crcx_ran_reject' time='31.279836'>
- <failure type='fail-verdict'>Timeout waiting for channel release
MSC_Tests.ttcn:1856 MSC_Tests control part
- MSC_Tests.ttcn:1283 TC_mo_crcx_ran_reject testcase
+ MSC_Tests.ttcn:1148 TC_establish_and_nothing testcase
</failure>
</testcase>
- <testcase classname='MSC_Tests' name='TC_mt_crcx_ran_reject' time='31.062826'>
- <failure type='fail-verdict'>Timeout waiting for channel release
+ <testcase classname='MSC_Tests' name='TC_mo_setup_and_nothing' time='31.570211'>
+ <failure type='fail-verdict'>Timeout waiting for ClearCommand/Release
MSC_Tests.ttcn:1857 MSC_Tests control part
- MSC_Tests.ttcn:1380 TC_mt_crcx_ran_reject testcase
+ MSC_Tests.ttcn:1172 TC_mo_setup_and_nothing testcase
</failure>
</testcase>
- <testcase classname='MSC_Tests' name='TC_mo_setup_and_dtmf_dup' time='2.468132'/>
- <testcase classname='MSC_Tests' name='TC_gsup_cancel' time='1.259044'>
+ <testcase classname='MSC_Tests' name='TC_mo_crcx_ran_timeout' time='5.327838'/>
+ <testcase classname='MSC_Tests' name='TC_mo_crcx_ran_reject' time='1.344745'/>
+ <testcase classname='MSC_Tests' name='TC_mt_crcx_ran_reject' time='31.111087'>
+ <failure type='fail-verdict'>Timeout waiting for channel release
+ MSC_Tests.ttcn:1860 MSC_Tests control part
+ MSC_Tests.ttcn:1383 TC_mt_crcx_ran_reject testcase
+ </failure>
+ </testcase>
+ <testcase classname='MSC_Tests' name='TC_mo_setup_and_dtmf_dup' time='2.732785'/>
+ <testcase classname='MSC_Tests' name='TC_gsup_cancel' time='1.330964'>
<error type='DTE'></error>
</testcase>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_1_13' time='1.049565'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_13' time='1.054199'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_1' time='1.034815'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_1_no_cm' time='1.038335'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_13_2' time='1.042416'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_013_2' time='1.050732'/>
- <testcase classname='MSC_Tests' name='TC_mo_release_timeout' time='25.264303'/>
- <testcase classname='MSC_Tests' name='TC_lu_and_mt_call_no_dlcx_resp' time='10.273413'/>
- <testcase classname='MSC_Tests' name='TC_reset_two' time='2.999986'/>
- <testcase classname='MSC_Tests' name='TC_lu_and_mt_call' time='4.284560'/>
- <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug' time='1.040196'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_1_13' time='1.133688'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_13' time='1.115280'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_1' time='1.071593'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_1_no_cm' time='1.111861'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_13_2' time='1.103937'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_013_2' time='1.115820'/>
+ <testcase classname='MSC_Tests' name='TC_mo_release_timeout' time='25.326450'/>
+ <testcase classname='MSC_Tests' name='TC_lu_and_mt_call_no_dlcx_resp' time='10.357978'/>
+ <testcase classname='MSC_Tests' name='TC_reset_two' time='3.038000'/>
+ <testcase classname='MSC_Tests' name='TC_lu_and_mt_call' time='4.395712'/>
+ <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug' time='1.124996'/>
</testsuite>
--
To view, visit https://gerrit.osmocom.org/7767
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I806491741d310e4410f6cb4ce0309235e9bf4300
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder