[PATCH] osmo-bsc[master]: bsc_nat: forward_to_bsc: Fix memleak on send failure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Apr 11 15:12:13 UTC 2018


bsc_nat: forward_to_bsc: Fix memleak on send failure

Change-Id: I56235eb05e4beed1bf9151319b64d67de4718e36
---
M src/osmo-bsc_nat/bsc_nat_ctrl.c
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/7758/2

diff --git a/src/osmo-bsc_nat/bsc_nat_ctrl.c b/src/osmo-bsc_nat/bsc_nat_ctrl.c
index 5f82a41..5d551ac 100644
--- a/src/osmo-bsc_nat/bsc_nat_ctrl.c
+++ b/src/osmo-bsc_nat/bsc_nat_ctrl.c
@@ -220,7 +220,7 @@
 	int ret = CTRL_CMD_HANDLED;
 	struct ctrl_cmd *bsc_cmd = NULL;
 	struct bsc_connection *bsc;
-	struct bsc_cmd_list *pending;
+	struct bsc_cmd_list *pending = NULL;
 	unsigned int nr;
 	char *bsc_variable;
 
@@ -293,6 +293,7 @@
 	cmd->reply = "no BSC with this nr";
 err:
 	ret = CTRL_CMD_ERROR;
+	talloc_free(pending);
 done:
 	talloc_free(bsc_cmd);
 	return ret;

-- 
To view, visit https://gerrit.osmocom.org/7758
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I56235eb05e4beed1bf9151319b64d67de4718e36
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list