[MERGED] libosmo-abis[master]: configure.ac: Fix condition check for RTP_SIGNAL_PTR_CAST de...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Apr 11 06:00:33 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: configure.ac: Fix condition check for RTP_SIGNAL_PTR_CAST define
......................................................................


configure.ac: Fix condition check for RTP_SIGNAL_PTR_CAST define

While building libosmo-netif on a system with an old ortp (0.22), it
was seen that warning related to RTP_SIGNAL_PTR_CAST not being correctly
selected were being printed. The compilation didn't fail there as
expected because the issue was being handled as a warning instead of an
error, so the void* ptr case was always being selected.

Change-Id: Ib5e7569e68fdb921c63e0c12e20e73aafbebda46
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index ce4bf39..05fbb12 100644
--- a/configure.ac
+++ b/configure.ac
@@ -110,7 +110,7 @@
 CFLAGS=$_cflags_save
 
 _cflags_save=$CFLAGS
-CFLAGS="$CFLAGS $ORTP_CFLAGS"
+CFLAGS="$CFLAGS $ORTP_CFLAGS -Werror"
 AC_COMPILE_IFELSE(
 	[AC_LANG_PROGRAM(
 		[[#include <ortp/ortp.h>

-- 
To view, visit https://gerrit.osmocom.org/7733
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5e7569e68fdb921c63e0c12e20e73aafbebda46
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list