osmo-msc[master]: libmsc/ussd.c: cosmetic: correct logging level

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Apr 9 18:02:45 UTC 2018


Patch Set 2:

> My point is that we're actually reporting a parser error here, not
 > an "unhandled message".  "unhandled" sounds to me like "unhandled
 > because there's no USSD code present".

I am not the author of the original logging message.

As I pointed out, the gsm0480_decode_ss_request() may
return 1 either in case of parsing error, either in case
if there's no USSD code present, either in case of any
other internal API problem :/

The main idea of this change is just to make such cases
*visible* for the OsmoMSC user. Usually, 'error' logging
level is used, so an USSD-request could be rejected without
any traces in the logging output.

-- 
To view, visit https://gerrit.osmocom.org/7675
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6c270fae54ce79c2708c99d7762ce6ff71f43d9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list