libosmo-netif[master]: stream.c: osmo_stream_cli_open2: Remove wrong assumption in ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Apr 5 22:39:12 UTC 2018


Patch Set 1:

I was having the same concerns why looking at this. I was thinking more in the differentiation between "temporary" errors or more "permanent" errors, which would not be solved over time, but ended up concluding what you see in this commit.

I thought of different scenarios, but realized most of them are actually temporary, be they more or less difficult to solve/change over time, but temporary over all. For instance:
- CONNRESFUSED -> may change over time if the service goes up or if there's a topology change in the network/routing.
- Protocol Not Supported: It can actually change if you load for instance the sctp module after starting osmo-msc.
- Address in use: Can be available at some point if the other process using it finishes (or it already finished but the kernel didn't release the socket completely yet).
- Network unreachable: can change due to network topology.
- Timeout: can change due to network topology.

In any case, adding extra info to differentiate those errors would mean changing the API, or extending it by setting errno explicitly in the implementation and documenting it.

-- 
To view, visit https://gerrit.osmocom.org/7650
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25b33f4cdc496ae31ff240d445b9b2805091845c
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list