This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/7625/1/include/osmocom/gsm/gsm0480.h File include/osmocom/gsm/gsm0480.h: Line 77: uint8_t ussd_data[GSM0480_USSD_OCTET_STRING_LEN]; why do we have the new fields in addition to the old fields? Can a single message contain both text and data? Wouldn't a union between those two make sense? Or do you think it's usefule to have the raw data and the decoded text (if any) in parallel in this structure? https://gerrit.osmocom.org/#/c/7625/1/src/gsm/gsm0480.c File src/gsm/gsm0480.c: Line 593: num_chars = GSM0480_USSD_OCTET_STRING_LEN; I'm not sure silent truncation is a good idea. This should IMHO at least lead to some kind of warning in the logs, if not an outright reject of the message. What are your thoughts? -- To view, visit https://gerrit.osmocom.org/7625 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia193d175021e145bb3b131290231f307dbefc64a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes