osmo-ttcn3-hacks[master]: test GGSN support for optional GTP-U sequence numbers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Apr 3 22:27:44 UTC 2018


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/7623/1/ggsn_tests/GGSN_Tests.ttcn
File ggsn_tests/GGSN_Tests.ttcn:

Line 196: 			} while (g_d_seq_nr == 0);
All this way of differentiating looks tricky. What about if we want to test wraparound of seq numbers? it's not possible as 0 will be skipped.

Or is it expected as per specs that seq=0 when it's not used?


Line 902: 		f_pdp4_clients_interact();
Aren't you modifying the default value used for use_gptu_txseq here and thus changing how test behave depending on order? 

Probably should should save the old value and restore it after the test.


-- 
To view, visit https://gerrit.osmocom.org/7623
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc299407c61b1c865035add44067b8ab89001b3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list