libosmocore[master]: CTRL: GET parsing: add '\n' as token delimiter

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Sep 27 14:01:26 UTC 2017


Patch Set 1: Code-Review-2

> What about \r and \t?

I'm not sure yet which way we want to go there. Should we disallow all whitespace other than plain space? Maybe still allow anything within the value part? Technically there could be a CTRL command to send an SMS with arbitrary special characters, as long as it doesn't interfere.

I'm also not sure about this one here, it only looked like it made sense because '\n' was used in the 'SET' command parsing.

I need some more reflecting on this I guess.

-- 
To view, visit https://gerrit.osmocom.org/4068
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33efb56f76cb7a41e94454666e218617e9b713ae
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list