This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged. Change subject: libosmo-legacy-mgcp: fix link against libgsm ...................................................................... libosmo-legacy-mgcp: fix link against libgsm libosmo-legacy-mgcp was not linked against libgsm when built with --enable-mgcp-transcoding. When afterwards a binary such as osmo-bsc is built and tries to link against it, it will fail with an error like the one below: /home/pespin/dev/sysmocom/bin/../build/new/out/lib/libosmo-legacy-mgcp.so: undefined reference to `gsm_create' Tested that building with this patch fixes the issue. Also tested that it still builds fine without --enable-mgcp-transcoding. Change-Id: I5ed356ac0c8f476e263fc6dcc5613d594890dfcd --- M src/libosmo-legacy-mgcp/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-legacy-mgcp/Makefile.am b/src/libosmo-legacy-mgcp/Makefile.am index bcf6242..ede1da4 100644 --- a/src/libosmo-legacy-mgcp/Makefile.am +++ b/src/libosmo-legacy-mgcp/Makefile.am @@ -19,6 +19,7 @@ $(LIBOSMONETIF_LIBS) \ $(COVERAGE_LDFLAGS) \ $(LIBBCG729_LIBS) \ + $(LIBRARY_GSM) \ $(NULL) # This is not at all related to the release version, but a range of supported -- To view, visit https://gerrit.osmocom.org/4066 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ed356ac0c8f476e263fc6dcc5613d594890dfcd Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>