libosmocore[master]: vty: install 'exit', 'end', ... commands on *all* nodes

[Neels Hofmeyr]

Patch Set 3: Code-Review-1

Now I found some fallout, failing in osmo-sgsn:

libosmocore gprs_bssgp_vty.c installs custom exit and end commands:

        /* Down vty node level. */
        gDEFUN(libgb_exit,
               libgb_exit_cmd, "exit", "Exit current mode and down to previous mode\n")
        {
                switch (vty->node) {
                case L_NS_NODE:
                case L_BSSGP_NODE:
                        vty->node = CONFIG_NODE;
                        vty->index = NULL;
                        break;
                default:
                        break;
                }
                return CMD_SUCCESS;
        }

        /* End of configuration. */
        gDEFUN(libgb_end,
               libgb_end_cmd, "end", "End current mode and change to enable mode.")
        {
                switch (vty->node) {
                case L_NS_NODE:
                case L_BSSGP_NODE:
                        vty_config_unlock(vty);
                        vty->node = ENABLE_NODE;
                        vty->index = NULL;
                        vty->index_sub = NULL;
                        break;
                default:
                        break;
                }
                return CMD_SUCCESS;
        }

To me it looks like stuff that would usually happen in the go_parent_cb().

It was created in

    commit 4f5883bc6ef83e692625de05e1d7297a0772d4c7
    Author: Harald Welte <laforge at gnumonks.org>
    Date:   Sat Jun 16 16:54:06 2012 +0800

Am I right to assume that it can be replaced by the way we exit nodes everywhere else?

-- 
To view, visit https://gerrit.osmocom.org/3998
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No