osmo-ggsn[master]: Move PDP logging macro to header

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Sep 23 05:33:17 UTC 2017


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/3961/1/gtp/pdp.h
File gtp/pdp.h:

Line 19: 	LOGP(DGGSN, level, "PDP(%s:%u): " fmt, imsi_gtp2str(&(pdp)->imsi), (pdp)->nsapi, ## args)
The idea seems fine, but you cannot assume that all users of this macro will have a "DGGSN" log level. Not everyone is a GGSN...


-- 
To view, visit https://gerrit.osmocom.org/3961
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79aba10ef989384a28f059c30899e65c771ae5e1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list