libosmocore[master]: vty: derive node name from prompt, use as XML ids

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Sep 21 05:32:02 UTC 2017


Patch Set 5: Code-Review+1

I like the idea, but why not simply add the "name" attribute in addtion to the existing "node-id" attribute?  This way the old 'vty-additions.xml' would still work, while we could write new ones referring to the names?  In any case, if that adds extra work for some reason I'm missing here, nevermind. We can merge it and convert the vty-additions.xml very easily - and as you have stated, this doesn't have to happen at the same time.

-- 
To view, visit https://gerrit.osmocom.org/3979
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fa555570268b231c5e01727c661da92fad265de
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list