osmo-pcu[master]: Simplify TS alloc: replace debug printer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Sep 20 17:20:20 UTC 2017


Patch Set 5:

> Where is the recursion?

For example: set_flag_chars(set_flag_chars(set_flag_chars(slot_info,

> snprintf in call sites is not really an improvement

Why? What's bad about it?

> Method is called print while it is a format

Just like sprintf(). Anyway, renamed it. Too bad we can't rename standard functions.

> newer libosmocore without bumping minimum version in configure.ac

It's not part of any release yet so I don't know to which version to bump to.

-- 
To view, visit https://gerrit.osmocom.org/3929
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia13855877b2145cb57b1646f5562b2af3b87bcfb
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list